feat(metrics): initialise MULTIPLEXED_METRIC_ROUTING_KEY for routing #19096
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
Hi @chargome, the PR is ready to review. Thanks ! |
chargome
left a comment
chargome
left a comment
There was a problem hiding this comment.
Nice, thanks for opening the PR! I left some comments. Also, we definitely want to test this behaviour somehow in a browser integration test.
| const container = Array.isArray(item) ? (item[1] as SerializedMetricContainer) : undefined; | ||
| const containerItems = container?.items; | ||
| if (containerItems) { | ||
| metric = containerItems[0]; |
There was a problem hiding this comment.
Wouldn't this mean we always just pull the first metric?
There was a problem hiding this comment.
yes it would mean we pull the first metric. What I'm thinking now after your comment is that I can add a logic which will check if all metrics and route to same or multiple destinations. Whats your opinion ?
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| getSpanStatusFromHttpCode, | ||
| setHttpStatus, | ||
| makeMultiplexedTransport, | ||
| MULTIPLEXED_TRANSPORT_EXTRA_KEY, |
There was a problem hiding this comment.
Removed public export breaks browser SDK users
High Severity
MULTIPLEXED_TRANSPORT_EXTRA_KEY was removed from the @sentry/browser re-exports. This constant is part of the public API — the CHANGELOG even shows users importing it from @sentry/browser. Removing it is a breaking change that will cause import errors for existing consumers, violating the rule against removing publicly exported symbols without deprecation.
Triggered by project rule: PR Review Guidelines for Cursor Bot
2 participants
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).Closes #18913
What changed
metricsMetricRoutingInfowith dsn and release as its fieldMetricOptionsand enabledcaptureMetricto inject routing info into attributesInternalCaptureMetricOptions_stripRoutingAttributesfunction which removes routing info before sending to sentry